protodoc: render map fields as map<K, V> instead of repeated map<K, V>#46065
Merged
jwendell merged 1 commit intoJul 10, 2026
Merged
Conversation
protoc represents a map<K, V> field as a repeated MapEntry message, so its label is LABEL_REPEATED and the docs template prefixed the (correct) map<K, V> rendering with "repeated". Suppress the label prefix for map fields, using the same map_typenames check that _json_value already uses. Fixes envoyproxy#32523 Signed-off-by: David Vo <davidvo@lyft.com>
|
Hi @davidvo-lyft, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
jwendell
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protoc represents a
map<K, V>field as a repeated MapEntry message, so its label isLABEL_REPEATEDand the docs template prefixed the (already correct)map<K, V>rendering with "repeated". This suppresses the label prefix for map fields, using the samemap_typenamescheck_json_valuealready uses.Risk Level: Low (doc tooling only)
Testing: regenerated the route/v3 API docs — the 4
repeated map<>renderings becomemap<>; genuine repeated fields keep their prefix.Docs Changes: generated API docs only
Release Notes: n/a
Fixes #32523