reverse_tunnel: allow requests without headers to reach clusters - #46296
Merged
Conversation
Previously, for a request to be sent across the reverse tunnel, the HTTP headers were read to determine the destination. However, if a request is forwarded from the TCP proxy filter, the downstream HTTP headers are not available. Thus, we allow requests to proceed to host selection even with no headers available. If the formatter context is a constant string, it will still able to evaluate to a valid host. A formatter context that parses headers and receives a downstream connection with no headers will still not evaluate to a host. Signed-off-by: Glenn Chen <glenn.chen@nutanix.com>
glennc24
requested review from
agrawroh,
botengyao and
yanavlasov
as code owners
July 21, 2026 21:05
glennc24
had a problem deploying
to
external-contributors
July 21, 2026 21:05 — with 
GitHub Actions
Error
GitHub Actions
Error
|
Hi @glennc24, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
basundhara-c
approved these changes
Jul 22, 2026
Contributor
|
/retest |
Contributor
|
@agrawroh , @yanavlasov this looks good to me. I think CI needs maintainer authorization here, could you help authorize? |
agrawroh
approved these changes
Aug 5, 2026
glennc24
temporarily deployed
to
external-contributors
August 5, 2026 01:28 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
agrawroh
enabled auto-merge (squash)
August 5, 2026 01:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Previously, for a request to be sent across the reverse tunnel, the HTTP headers were read to determine the destination. However, if a request is forwarded from the TCP proxy filter, the downstream HTTP headers are not available.
Thus, we allow requests to proceed to host selection even with no headers available. If the formatter context is a constant string, it will still able to evaluate to a valid host. A formatter context that parses headers and receives a downstream connection with no headers will still not evaluate to a host.
Additional Description:
Risk Level: Low
Testing: Unit Test Added
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]