otel_access_log: support resource detectors for defining monitored resource by TAOXUY · Pull Request #47128 · envoyproxy/envoy

TAOXUY · 2026-09-01T18:02:50Z

Commit Message:
Add support for OpenTelemetry resource detectors in the OpenTelemetry access logger. This allows users to detect resource attributes from env.

Additional Description:

Added resource_detectors to OpenTelemetryAccessLogConfig proto.
Integrated ResourceProvider with otlp_log_utils to execute configured resource detectors and populate detected attributes and schema URL.
Added comprehensive unit tests for config, message root initialization, gRPC logger, and HTTP logger.

AI Assistance: This change was developed with the assistance of an AI coding agent (Jetski/Gemini). The author has reviewed, verified, tested, and takes full ownership of all submitted code.

Risk Level: Low
Testing: Added unit tests in otlp_log_utils_test, config_test, grpc_access_log_impl_test, and http_access_log_impl_test.
Docs Changes: Updated proto documentation and release notes in changelogs/current.yaml.
Release Notes: Added under access_loggers.

repokitteh-read-only · 2026-09-01T18:03:03Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #47128 was opened by TAOXUY.

see: more, trace.

…source Commit Message: Add support for OpenTelemetry resource detectors in the OpenTelemetry access logger. This allows users to dynamically detect and populate resource attributes and schema URL from environment variables or custom resource detectors. Additional Description: - Added resource_detectors to OpenTelemetryAccessLogConfig proto. - Integrated ResourceProvider with otlp_log_utils to execute configured resource detectors and populate detected attributes and schema URL. - Updated gRPC and HTTP access logger implementations and caches to pass ServerFactoryContext. - Added comprehensive unit tests for config, message root initialization, gRPC logger, and HTTP logger. Risk Level: Low Testing: Added unit tests in otlp_log_utils_test, config_test, grpc_access_log_impl_test, and http_access_log_impl_test. Docs Changes: Updated proto documentation and release notes in changelogs/current.yaml. Release Notes: Added under access_loggers. Signed-off-by: Xuyang Tao <taoxuy@google.com>

TAOXUY · 2026-09-01T18:13:10Z

CC @kyessenov

kyessenov

Mostly minor comments. I think you need to handle merging. Can you modify an existing integration test to set some static attributes via resource detector?

kyessenov · 2026-09-01T18:54:20Z

 namespace OpenTelemetry {

+namespace {
+using opentelemetry::proto::collector::logs::v1::ExportLogsServiceRequest;


Why is this change needed?

kyessenov · 2026-09-01T18:55:13Z

+  // Attributes detected by ``resource_detectors`` will be added to the resource attributes.
+  // If both ``resource_detectors`` and ``resource_attributes`` are specified, the attributes from
+  // ``resource_detectors`` are added first, and any attributes configured in ``resource_attributes``
+  // are appended afterwards.


How are conflicts resolved? Are they overriding each other?

kyessenov · 2026-09-01T18:56:46Z

+      resource_logs->set_schema_url(detected_resource.schema_url_);
+    }
+    for (const auto& [key, value] : detected_resource.attributes_) {
+      *resource->add_attributes() = getStringKeyValue(key, value);


I think this may cause conflicts with the other attribute setters? Seems like there could be duplicated keys.

kyessenov · 2026-09-01T18:57:07Z

        config,
-    const LocalInfo::LocalInfo& local_info);
+    Server::Configuration::ServerFactoryContext& context,
+    const Extensions::Tracers::OpenTelemetry::ResourceProvider& resource_provider =


Please use OptRef to avoid unnecessary allocations.

Commit Message: otel_access_log: address review comments Additional Description: - Documented attribute precedence and deduplication in proto comments. - Enforced attribute precedence order (resource_attributes > resource_detectors > built-in labels) and avoided duplicate keys in otlp_log_utils. - Updated initOtlpMessageRoot to accept OptRef<const ResourceProvider> to avoid unnecessary allocations. - Fixed [[nodiscard]] test warnings and removed unused namespace in http_access_log_impl.cc. - Added unit tests for attribute precedence and deduplication. Risk Level: Low Testing: Added unit tests and verified all tests pass. Docs Changes: Updated proto documentation. Release Notes: N/A Signed-off-by: Xuyang Tao <taoxuy@google.com>

Commit Message: test: fix undeclared variables in otlp_log_utils_test Additional Description: Use kTestZone, kTestCluster, and kTestNode constants in InitOtlpMessageRootAttributePrecedenceAndDeduplication to fix compilation failure. Risk Level: Low Testing: Fixed unit test compilation. Docs Changes: N/A Release Notes: N/A Signed-off-by: Xuyang Tao <taoxuy@google.com>

kyessenov · 2026-09-02T00:11:38Z

  auto* root = resource_logs->add_scope_logs();
  auto* resource = resource_logs->mutable_resource();
+
+  std::vector<opentelemetry::proto::common::v1::KeyValue> attributes;


You could probably just use RepeatedPtrField<string>*?

… test Commit Message: otel_access_log: optimize attribute allocation and update integration test Additional Description: - Directly mutate RepeatedPtrField in initOtlpMessageRoot to avoid intermediate vector allocations. - Updated access log integration test to configure resource detectors and verify detected resource attributes. Risk Level: Low Testing: Verified unit and integration test configs. Docs Changes: N/A Release Notes: N/A Signed-off-by: Xuyang Tao <taoxuy@google.com>

TAOXUY requested a review from yanavlasov as a code owner September 1, 2026 18:02

repokitteh-read-only Bot added the api label Sep 1, 2026

repokitteh-read-only Bot assigned wbpcode Sep 1, 2026

TAOXUY force-pushed the otel-access-log-resource-detector branch from 37d9961 to 6558427 Compare September 1, 2026 18:11

TAOXUY force-pushed the otel-access-log-resource-detector branch from 6558427 to 747cbdb Compare September 1, 2026 18:12

TAOXUY changed the title ~~otel_access_log: support resource detectors for defining monitored re…~~ otel_access_log: support resource detectors for defining monitored resource Sep 1, 2026

kyessenov requested changes Sep 1, 2026

View reviewed changes

kyessenov self-assigned this Sep 1, 2026

TAOXUY force-pushed the otel-access-log-resource-detector branch 2 times, most recently from 7614d3e to 72ee3ae Compare September 1, 2026 21:34

TAOXUY changed the title ~~otel_access_log: support resource detectors for defining monitored resource~~ [WIP]otel_access_log: support resource detectors for defining monitored resource Sep 1, 2026

TAOXUY force-pushed the otel-access-log-resource-detector branch from 72ee3ae to 0f4f7e8 Compare September 1, 2026 21:44

TAOXUY changed the title ~~[WIP]otel_access_log: support resource detectors for defining monitored resource~~ otel_access_log: support resource detectors for defining monitored resource Sep 1, 2026

kyessenov reviewed Sep 2, 2026

View reviewed changes

Navigation Menu

Uh oh!

otel_access_log: support resource detectors for defining monitored resource - #47128

otel_access_log: support resource detectors for defining monitored resource#47128
TAOXUY wants to merge 4 commits into
envoyproxy:mainfrom
TAOXUY:otel-access-log-resource-detector

TAOXUY commented Sep 1, 2026 •

edited

Loading

Uh oh!

repokitteh-read-only Bot commented Sep 1, 2026

Uh oh!

TAOXUY commented Sep 1, 2026

Uh oh!

kyessenov left a comment

Uh oh!

kyessenov Sep 1, 2026

Uh oh!

TAOXUY Sep 1, 2026

Uh oh!

kyessenov Sep 1, 2026

Uh oh!

TAOXUY Sep 1, 2026

Uh oh!

kyessenov Sep 1, 2026

Uh oh!

TAOXUY Sep 1, 2026

Uh oh!

kyessenov Sep 1, 2026

Uh oh!

TAOXUY Sep 1, 2026

Uh oh!

kyessenov Sep 2, 2026

Uh oh!

TAOXUY Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

TAOXUY commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Sep 1, 2026

Uh oh!

TAOXUY commented Sep 1, 2026

Uh oh!

kyessenov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TAOXUY commented Sep 1, 2026 •

edited

Loading