listener: create generic listener filter timeout#5231
Merged
Conversation
Move the hard-coded 15s timeout in TLS inspector into the connection handler such that it covers all listener filters. Also make it configurable as well as add useful stats to see how many connections are currently undergoing listener filter processing. Fixes #5217 Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@ggreenway @PiotrSikora PTAL |
venilnoronha
reviewed
Dec 6, 2018
alyssawilk
reviewed
Dec 6, 2018
alyssawilk
left a comment
alyssawilk
left a comment
Contributor
There was a problem hiding this comment.
Just a few nits on my end
| to a response with empty body. | ||
| * listeners: all listener filters are now governed by the :ref:`listener_filters_timeout | ||
| <envoy_api_field_Listener.listener_filters_timeout>` setting. The hard coded 15s timeout in | ||
| the :ref:`TLS inspector listener filter <config_listener_filters_tls_inspector>` is superseded by |
Contributor
There was a problem hiding this comment.
The prior TLS inspector listener filter timeout is replaced, not the TLS inspector listener, right?
Member
Author
There was a problem hiding this comment.
It reads: "The hard coded 15s timeout in the TLS inspector listener filter is superseded by..." I think that is OK?
| COUNTER(connection_closed) \ | ||
| COUNTER(client_hello_too_large) \ | ||
| COUNTER(read_error) \ | ||
| COUNTER(read_timeout) \ |
Contributor
There was a problem hiding this comment.
Looks like there aren't docs to update here. Non-blocking but maybe file a bug against Greg or Piotr to doc up the stats we have?
Signed-off-by: Matt Klein <mklein@lyft.com>
alyssawilk
approved these changes
Dec 6, 2018
alyssawilk
approved these changes
Dec 6, 2018
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Move the hard-coded 15s timeout in TLS inspector into the connection handler such that it covers all listener filters. Also make it configurable as well as add useful stats to see how many connections are currently undergoing listener filter processing. Fixes envoyproxy#5217 Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the hard-coded 15s timeout in TLS inspector into
the connection handler such that it covers all listener
filters. Also make it configurable as well as add useful
stats to see how many connections are currently undergoing
listener filter processing.
Fixes #5217
Risk Level: Medium
Testing: Unit tests
Docs Changes: Done
Release Notes: Done