Small pnpm adjustments#1175
Merged
Merged
Conversation
- adjust dependencies - remove unused exports - refine knip config
JulienVig
approved these changes
Jul 3, 2026
Collaborator
There was a problem hiding this comment.
Is there a place to document why we're using supports-color for future confused others?
| ``` | ||
| corepack enable | ||
| corepack use pnpm | ||
| curl -fsSL https://get.pnpm.io/install.sh | sh - |
Collaborator
There was a problem hiding this comment.
Maybe we should simply point to their installation instructions as we did for nvm, this command only runs for POSIX but also doesn't work for Mac Intel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last devops PR (until next time =)
Change the static file dependency on
isomorphic-wrtcto a workspace dependency. Works the same way but makes the Dockerfile slightly simpler and more maintainable, and allows dropping thesyncInjectedDepsAfterScripts.Also add a useless
supports-colordependency to work against a pnpm bug and allow deduplicating dependencies. Hopefully we can drop it in future pnpm versions.Finally, drop corepack usage, as it's getting phased out.
The numerous commits is due to me messing up rebases, don't mind it.