Revive the AppVeyor matrix: osiSocklen_t portability + Python 3 pin - #239
Merged
MarkRivers merged 2 commits intoJul 21, 2026
Merged
Conversation
socklen_t is POSIX, not C; Base 3.14 on Windows defines neither it nor a header that does, so drvAsynIPPort.c:546 fails to compile there (AppVeyor BASE=3.14 vs2019 jobs, error C2065). osiSocklen_t from osiSock.h is the EPICS-portable spelling and the type the rest of the tree already uses.
The default (VS2015) and VS2017 worker images resolve python/pip to Python 2.7, and ci-core-dumper now requires >= 3.8, so every job on those images dies in the install phase before compiling anything. Prepend C:\Python38-x64 and invoke pip as "python -m pip" (a bare pip would still resolve to C:\Python27\Scripts), copying the install stanza epics-base uses with the same images.
physwkim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes that revive the broken AppVeyor matrix:
drvAsynIPPort.c:546—socklen_t(from Nonblocking connect using poll #211) is POSIX, and Base 3.14 on Windows defines neither it nor a header that does, so theBASE=3.14vs2019 jobs fail witherror C2065: socklen_t: undeclared identifier. Base 7.0 gets it via the newer WinSock headers, which is why only the 3.14 jobs break.osiSocklen_tfromosiSock.h(already included) is the EPICS-portable spelling; on POSIX it issocklen_t, so no behavior change. This is the only baresocklen_tin the tree..appveyor.yml— the default (VS2015) and VS2017 images resolvepython/pipto Python 2.7, andci-core-dumpernow requires >= 3.8, so every gcc/vs2013/vs2015/vs2017 job dies in the install phase before compiling anything. PinC:\Python38-x64ontoPATHand invoke pip aspython -m pip, copying the install stanza epics-base uses with the same images.