Skip to content

Conversation

@nikosbosse
Copy link
Collaborator

Description

This PR closes #1005.

For scoring ordinal forecasts, we require functionality that was introduced in scoringRules v1.1.2. This PR therefore updates the dependency accordingly,

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Are you aware of any approaches to testing if we have this kind of dependency in the future? I am not so maybe we just need an issue to track?

@seabbs seabbs merged commit 6607c52 into main Jun 17, 2025
9 checks passed
@seabbs seabbs deleted the scoringRules-version branch June 17, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimum version of scoringRules required for correct current scoringutils functionality.

3 participants