Skip to content

Conversation

@sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jun 24, 2025

Description

This PR closes #1009.

Whilst there also fixes another bug later on.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs enabled auto-merge June 24, 2025 15:53
@seabbs seabbs merged commit dfb8caf into main Jun 24, 2025
9 checks passed
@seabbs seabbs deleted the pit-dont-round branch June 24, 2025 16:01
@nikosbosse
Copy link
Collaborator

@sbfnk could you give a slightly more detailed description of the bug? If I understand correctly

  • we incorrectly always computed the discrete version of the histogram
  • we rounded numbers inappropriately
    Is that correct?

@sbfnk
Copy link
Contributor Author

sbfnk commented Jun 25, 2025

Yes, exactly. Not quite sure where the rounding came from but it might be a leftover from inserting a statement for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PIT histogram will always use the integer version

4 participants