-
Notifications
You must be signed in to change notification settings - Fork 25
Rework summarise_scores() and pairwise_comparison()
#368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… even if they get lost in data.table operations
… and explicitly store `by` and unsummarised scores as attributes
… about how forecast units are handled)
…mes of the metrics used during scoring into account
…orecast_unit, update usage of add_pairwise_comparison in vignette code.
… there in some places
Merged
seabbs
approved these changes
Nov 7, 2023
Contributor
seabbs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
add_pairwise_comparison()away fromsummarise_scores(), such that the two operations now happen in 2 independent steps.add_coverage()such that it also works after summarising scoresThinking:
add_pairwise_comparison()now works on anunsummarised_scoresattribute. This means that you can't do it twice at the moment. Also the output column is justrelative_skill, notrelative_skill_myscore, so it would be overridden anyway. Are we fine with this?To do:
unsummarised_scoresattribute --> meaning that you can't do it twice at the moment.