Skip to content

Conversation

@nikosbosse
Copy link
Collaborator

This PR

  • adds functionality to get, store, and restore attributes to scoringutils objects. These need to be handled manually, as attributes often don't survive certain data.table operations. This was started here, but is not yet done consistently everywhere
  • makes some minor improvements (changes? :P ) to internal check functions
  • splits an new function add_pairwise_comparison() away from summarise_scores(), such that the two operations now happen in 2 independent steps.
  • Modify add_coverage() such that it also works after summarising scores

Thinking:

  • add_pairwise_comparison() now works on an unsummarised_scores attribute. This means that you can't do it twice at the moment. Also the output column is just relative_skill, not relative_skill_myscore, so it would be overridden anyway. Are we fine with this?

To do:

  • need to update documentation to reflect that this now happens on the unsummarised_scores attribute --> meaning that you can't do it twice at the moment.

nikosbosse and others added 22 commits October 27, 2023 08:53
… even if they get lost in data.table operations
… and explicitly store `by` and unsummarised scores as attributes
…mes of the metrics used during scoring into account
…orecast_unit, update usage of add_pairwise_comparison in vignette code.
@nikosbosse nikosbosse requested a review from seabbs October 29, 2023 17:51
@nikosbosse nikosbosse mentioned this pull request Oct 30, 2023
Base automatically changed from rework-score() to scoringutils-review November 7, 2023 11:58
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikosbosse nikosbosse merged commit c745f9f into scoringutils-review Nov 7, 2023
@nikosbosse nikosbosse deleted the rework-summarise-scores branch November 7, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants