Rework quantile to interval format #377
Conversation
…coring for point forecasts
…by `quantile_to_interval()`
Codecov Report
@@ Coverage Diff @@
## intermediate-clean-up #377 +/- ##
========================================================
Coverage ? 85.54%
========================================================
Files ? 20
Lines ? 1570
Branches ? 0
========================================================
Hits ? 1343
Misses ? 227
Partials ? 0 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Do you want this reviewed @nikosbosse? |
|
Yes please! |
seabbs
left a comment
seabbs
left a comment
There was a problem hiding this comment.
The actual functionality is all fine but quite messy from a software dev perspective in terms of code listing and handling imports.
Only major comment is about the sister function that maps intervals back to quantiles.
| quantile_to_interval <- function(...) { | ||
| UseMethod("quantile_to_interval") | ||
| } | ||
|
|
seabbs
left a comment
seabbs
left a comment
There was a problem hiding this comment.
The actual functionality is all fine but quite messy from a software dev perspective in terms of code listing and handling imports.
Only major comment is about the sister function that maps intervals back to quantiles.
This (very modular and small PR 🐶 🐕 )
quantile_to_interval()with two methods for vectors and for a data.framequantile_to_range_long()which does the same thing for data.frames)