Skip to content

Conversation

@seabbs
Copy link
Contributor

@seabbs seabbs commented Jan 5, 2024

Description

This PR closes #555.

It removes interval_coverage_sample() and renames interval_coverage_quantile() and interval_coverage_dev_quantile() to interval_coverage() and interval_coverage_deviation().

Note that I have stored some of the useful helper code from interval_coverage_sample() in #557

By removing interval_coverage_sample() this PR also closes #411.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs requested a review from nikosbosse January 5, 2024 14:12
@seabbs seabbs changed the title Issue555 Issue 555: Rename interval_coverage_ family and remove sample version Jan 5, 2024
@codecov
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10641d6) 84.55% compared to head (62b5dd3) 85.14%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #558      +/-   ##
===========================================
+ Coverage    84.55%   85.14%   +0.59%     
===========================================
  Files           21       21              
  Lines         1722     1710      -12     
===========================================
  Hits          1456     1456              
+ Misses         266      254      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nikosbosse nikosbosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@nikosbosse nikosbosse merged commit 8afcbec into develop Jan 5, 2024
@nikosbosse nikosbosse deleted the issue555 branch January 5, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants