Move statistics customization to sidebar - #14031
Closed
MagnusSletten wants to merge 8 commits into
Closed
Conversation
Introduce a reusable style edit widget that adapts StyleChooser for compact use in the plot sidebar. It provides the shared layout and style handling needed by both ensemble and statistics controls, avoiding separate implementations for each sidebar section.
Collaborator
|
Screenshots differ from baselines. A baseline update PR has been prepared: equinor/ert-testdata#65 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14031 +/- ##
==========================================
+ Coverage 91.48% 91.50% +0.01%
==========================================
Files 487 488 +1
Lines 34086 34275 +189
==========================================
+ Hits 31184 31363 +179
- Misses 2902 2912 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
Closed due to the decision to move away from even more legacy code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #14030
Currently blocked by #14025 since it's based on some changes within that PR.
Approach
Added a collapsible statistics customization pane to the sidebar. The functionality remains the same, with one important change: the settings are no longer defined per key. Switching between keys therefore preserves the selected statistics styling.
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.