ci: Use uv instead of poetry#322
Merged
Merged
Conversation
sindre-nistad
approved these changes
Jun 10, 2025
Contributor
sindre-nistad
left a comment
sindre-nistad
left a comment
There was a problem hiding this comment.
Looks good,
We may need to test it on ARM64-based architectures in case the builder stage needs to install some compilers
einarwar
commented
Jun 10, 2025
eoaksnes
approved these changes
Jun 10, 2025
Collaborator
eoaksnes
left a comment
eoaksnes
left a comment
There was a problem hiding this comment.
This looks good 😄
Kudos for description of the changes done in PR overview 👍
einarwar
commented
Jun 10, 2025
Contributor
Author
Ehh, yeah i totally did that myself ... 😅 |
Collaborator
Ment the conversation :) |
mariuswinger
requested changes
Jun 10, 2025
Contributor
mariuswinger
left a comment
mariuswinger
left a comment
There was a problem hiding this comment.
Good improvements! Would prefer still having dev and prod targets for api/Dockerfile, so maybe add that back again using the feedback?
einarwar
force-pushed
the
use-uv-instead-of-poetry
branch
from
3b7514f to
c18601e
Compare
einarwar
force-pushed
the
use-uv-instead-of-poetry
branch
from
c18601e to
20b993a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
uvis quickly becoming the de-facto tool for everything package related. Its also much faster thanpoetry⚡What does this pull request change?
Replaces usage of
poetrywithuv. This applies to both dependency management, package installations and CI. Also updated docsThis pull request introduces significant changes to the project, primarily focusing on migrating from
Poetrytouvfor dependency and environment management, as well as updating the Docker setup and CI workflows. These changes aim to modernize the tooling, improve caching, and streamline dependency management.Migration to
uv:Poetrywithuvfor dependency management inapi/Dockerfileandapi/pyproject.toml. Updated commands to useuv sync,uv add, anduv removefor managing dependencies. [1] [2] [3]uvinstead ofPoetryfor dependency installation and management. [1] [2]CI Workflow Updates:
.github/workflows/linting-and-checks.yamlto replacesetup-pythonwithsetup-uv, enabling caching and usinguvcommands for dependency installation and running checks. [1] [2]Docker Configuration Changes:
ghcr.io/astral-sh/uv:bookworm-sliminapi/Dockerfile. Introduced multi-stage builds to optimize the final image by excluding development dependencies.docker-compose.override.ymlby removing thebuildsection for theapiservice.Project Configuration Updates:
pyproject.tomlto use theprojecttable format and updated dependency definitions to align withuvrequirements.buildconfiguration toradixconfig.yamlto enable BuildKit and caching for improved build performance.Issues related to this change:
Closes #321