Python3 #1024
Merged
Python3 #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennorehling
reviewed
Sep 16, 2023
Member
ennorehling
left a comment
ennorehling
left a comment
There was a problem hiding this comment.
Ich habe ein paar Fragen, weil ich schon lange nichts mehr mit Python mache, aber im großen und ganzen sieht das vernünftig aus, und genau die Sorte Änderungen, die ich erwartet hatte. Testen ist schwierig, denn das einzige Environment in dem ich das ganze benutze, ist der Live Server. Sogar die Test-Auswertung am Sonntag benutzt die selbe Version der Skripte aus ~/eressea/server, was mir schon eine Weile ein Ärgernis ist, vielleicht sollte ich das mal deutlicher separieren.
Member
|
Oh, ist schon gemacht,. Prima! |
ennorehling
added a commit
that referenced
this pull request
Nov 27, 2023
ennorehling
added a commit
that referenced
this pull request
Mar 2, 2024
ennorehling
added a commit
that referenced
this pull request
Mar 3, 2024
ennorehling
added a commit
that referenced
this pull request
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated to python3, mainly accept-orders.py. I have relatively low confidence in this and would like to see it tested more.