Conversation
kushti
approved these changes
Oct 14, 2024
Member
kushti
left a comment
kushti
left a comment
There was a problem hiding this comment.
@ergomorphic please take a look as well
kushti
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is only used by https://github.com/ergoplatform/ergo-tool, there is even a help message that mentions "ergotool", so it is appropriate to move it there instead. It does not make sense to include a CLI framework in appkit.
After removing all code related to this feature, there was only one Scala class left in the appkit module, so I rewrote it in Java to make it tidier.