Review from Group 16#1
Open
canondetortugas wants to merge 26 commits intoerichanslee:masterfrom
Open
Conversation
Fixed typo in documentation.
A fresh clone and make of this project warned me that `getopt` was
implicitly declared:
$ make
icc -c -std=c99 -g -O3 -no-prec-div -xcore-avx2 -ipo -qopt-report=5 -qopt-report-phase=vec -openmp path.c
icc: remark #10346: optimization reporting will be enabled at link time when performing interprocedural optimizations
path.c(214): warning #266: function "getopt" declared implicitly
while ((c = getopt(argc, argv, optstring)) != -1) {
^
path.c(214): warning #2330: argument of type "const char *" is incompatible with parameter of type "void *" (dropping qualifiers)
while ((c = getopt(argc, argv, optstring)) != -1) {
^
...
This StackOverflow post [1] says to remove the `-std=c99` flag or
explicitly include `getopt.h` to fix the problem. I opted for the
latter. After this fix, everythin builds without warning.
[1]: http://stackoverflow.com/a/22576057/3187068
Fixed a couple of typos in `path.c`.
Added missing `<getopt.h>` inclusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.