[pull] main from livekit:main - #443
Merged
Merged
Conversation
#1713) * Redact mux/twitch shorthand stream keys and websocket url query values mux:// and twitch:// shorthand stream urls carry the stream key as the entire authority, but RedactStreamKey only matched rtmp(s):// urls, so shorthand keys passed through redaction unchanged and ended up raw in request logs. Track egress websocket urls can carry credentials in query parameters and were not redacted at all. Also fixes RedactUpload reading AssumeRoleExternalId instead of SessionToken when redacting SessionToken. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Fix expected mux redaction suffix in TestRedactStreamOutput Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…s don't (#1715) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )