fix(pstack): preload poteto-mode in Claude agent - #50
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Greptile SummaryThis PR preloads the existing
Confidence Score: 4/5The production change appears safe to merge, with a non-blocking weakness in how the new live regression proves preload behavior. The frontmatter binding and static invariant are consistent with the package’s naming and delivery model; the only accepted concern is that the behavioral check can pass through an alternate skill-loading path because it asserts only the returned phrase. Files Needing Attention: tests/skill-collision-repro.sh
|
| Filename | Overview |
|---|---|
| plugins/pstack/agents/poteto-agent.md | Adds the canonical pstack:poteto-mode skill to the Claude agent’s preload frontmatter. |
| tests/skill-collision-repro.sh | Adds a sound static binding invariant, but the live check verifies only output text rather than whether the skill was actually preloaded. |
| docs/reference.md | Documents why the Claude-specific preload is required while preserving the existing agent invocation guidance. |
Reviews (1): Last reviewed commit: "fix(pstack): preload poteto-mode in Clau..." | Re-trigger Greptile
| --tools Agent \ | ||
| < /dev/null 2>&1 | ||
| )" | ||
| check "poteto-agent preloaded skill" "Laziness Protocol" "$preloaded_agent_output" |
There was a problem hiding this comment.
This regression only checks the child’s final text for Laziness Protocol. Asking the model not to invoke Skill or read files does not verify that restriction, especially because the agent description itself tells the child to read the poteto-mode skill. If the child obtains the phrase through that alternate path, the test passes without proving that frontmatter preloading worked. Consider asserting the child’s tool activity or making the expected value unavailable without the preload.
Knowledge Base Used: Testing and CI quality gates
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
@ericlitman This prerequisite is ready and blocks #52. The exact head still has the recorded live Claude preload evidence. I re-ran the repository suite today: 157 passed with only the already-documented baseline runner deadline test failing; static/plugin validation remains clean. Please merge #50 when ready so #52 can be rebased onto main and complete its Conductor acceptance. |
Closes #49
Why
Claude subagents start with isolated context and do not inherit skills loaded by their parent. The poteto-agent prompt named the skill, but the skill body was unavailable unless the child independently invoked Skill or read plugin files.
What changed
Blast radius
This changes only the Claude-native pstack:poteto-agent. The shared skill tree, Codex path, other agents, and external provider lanes are unchanged.
Verification
Live evidence: