Merge from upstream master#2
Merged
ericnewton76 merged 126 commits intoericnewton76:masterfrom Aug 7, 2018
Merged
Conversation
With the test helpers, when a directory is moved, any custom attributes such as hidden or system are not moved to the destination directory.
Ensure attributes follow when moving a directory
…lName to fix issue #215.
fix #210 - mock CreateDirectory should ignore existing directories
…ring Issue215 mock directory info to string
…n exception. Implementation note - instead of using System.IO.FileAccess/FileMode, I ended up creating an internal StreamType enum instead to keep the interface simple. That's potentially something to change upon on review, but I think it's good the way it is.
NET Standard compatibility v2
Appveyor csproj versioning
Don't publish the tests as a package
Now that we're only producing the right packages, we can deploy all of them to NuGet
Deploy correct packages
Only build PRs once, not once for the PR and once for the feature branch
Workaround for this issue which is prevent publishing: http://help.appveyor.com/discussions/problems/8215-cannot-publish-to-nuget-get-400-bad-request-error appveyor/ci#1825
Update nuget.exe during build script
Was picking up PR builds otherwise
The mid-build upgrade was an attempt to work around an AppVeyor publishing issue, however the AppVeyor NuGet provider doesn't use the command line app by default anyway. The AppVeyor environment has subseqently been upgraded to fix this properly, and we no longer get 400 errors when pushing to the NuGet service.
* Removed XOR of the MockFileData.Contents * Modified MockFileInfo Encrypt/Decrypt tests to cover the Encrypted attribute instead
* Implemented File.Replace, FileInfo.Replace Added File property to IMockFileDataAccessor * Fixed File exists check in MockFile.Replace * Added unit tests for FileInfo.Replace (5 tests) and File.Replace (4 tests) Tests are NET40 specific * Added explicit null argument checks to File.Replace * Cleaned up unit tests for File.Replace, FileInfo.Replace * Added tests that Replace should throw if backup is in missing directory
Add target for netstandard2.0, and shuffle along dependencies
Misc code cleanup
Make EnumerateFiles lazy Fixes #201
* Introduce SkipOnUnixAttribute and use it to simplify tests * Move SkipReason to separate file * Rename SkipOnUnixAttribute to WindowsOnlyAttribute * Improve windows-specific tests
Add inheritdoc comments to public types Fixes #245 Method comments reference System.IO.FileInfo via inheritdoc tag. * Add XML documentation file (#245) This enables the XML documentation file to be generated for both debug and release configurations. It allows the method comments to be formed into an XML documentation file and distributed alongside System.IO.Abstractions. * Fix incorrect parameter in inheritdoc cref * Add method comments to FileBase (#245) Method comments reference System.IO.File via inheritdoc tag. * Add method comments to PathBase (#245) Method comments reference System.IO.Path via inheritdoc tag. * Add method comments to DriveInfoBase (#245) Method comments reference System.IO.DriveInfo via inheritdoc tag. * Add method comments to FileSystemWatcherBase (#245) Method comments reference System.IO.FileSystemWatcher via inheritdoc tag. * Add class comment to DirectoryInfoBase (#245) Class comment reference System.IO.DirectoryInfo via inheritdoc tag. * Add class comment to FileBase (#245) Class comment reference System.IO.File via inheritdoc tag. * Add class comment to FileInfoBase (#245) Class comment reference System.IO.FileInfo via inheritdoc tag. * Add class comment to FileSystemWatcherBase (#245) Class comment references System.IO.FileSystemWatcher via inheritdoc tag. * Add method comments to FileSystemInfoBase (#245) Method comments reference System.IO.FileSystemInfo via inheritdoc tag. * Add class comment to PathBase (#245) Class comment references System.IO.Path via inheritdoc tag. * Add comments to DirectoryBase (#245) Comments reference System.IO.Directory via inheritdoc tag. * Add method comments to DirectoryInfoBase (#245) Method comments reference System.IO.DirectoryInfo via inheritdoc tag.
* Add FileStreamFactory and support for mocking FileStreams * Fix .NET Standard compile * Adapt MockFileStreamFactory to MockFileStream changes * Add missing ifdefs for MockFileStreamFactory * Use expression bodies * Delete unnecessary nuspec file * Simplify MockFileStreamFactory tests Fixes #224
Setting the XML documentation file through Project Properties/Build only generated the XML documentation file for NET40 and not netstandard1.4 nor netstandard2.0. Adding the property GenerateDocumentationFile and setting it to true generates the documentation for all build types.
This was supported for files before, but directories behave a little differenlty. This should better match .Net System.IO behavior.
* Implement AccessControl on FileInfo. * Addressed code review comments. - Moved namespaces - Fixed SetAccessControl* unit test names
* MockFileStream now blocks writing if created with the READ type * Enhanced MockFile.Open to take read mode into account * Unit tests now check for expected exceptions * Fixed MockFile_OpenWrite_ShouldCreateNewFiles * Review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.