polygon/bor: add borabi pkg - #11619
Merged
Merged
Conversation
taratorio
force-pushed
the
bor_event_abi_tidy
branch
from
August 14, 2024 18:38
353a90e to
cc00194
Compare
…to bor_event_abi_tidy
taratorio
marked this pull request as ready for review
August 15, 2024 09:45
antonis19
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to add
MarshallKey,MarshallValue(and correspondingUnmarshall) receiver functions onEventRecordWithTimewhich hide away theabidetail so callers don't have to deal with the ABI as a function input everywhere in the code base - PR #11620However there is a circular dependency which blocks me from doing that because
EventRecordWithTimeis in packagepolygon/heimdalland it importspolygon/borpackage forbor.GenesisContractStateReceiverABI, howeverpolygon/borimportspolygon/heimdallforEventRecordWithTimedue to the bor event fallback hack we have in Bor consensus engine (it is pending removal once we fix the underlying issue that led to it appearing which is a WIP).For now, to unblock myself I am moving the bor ABIs in a sub-package
polygon/bor/borabi