Revert "[wip] sd: removing txNum field "#19508
Merged
AskAlexSharov merged 2 commits intomainfrom Feb 27, 2026
Merged
Conversation
This reverts commit 3d203a2.
Giulio2002
requested review from
AskAlexSharov,
antonis19,
awskii,
mh0lt,
sudeepdino008,
taratorio and
yperbasis
as code owners
AskAlexSharov
approved these changes
Feb 27, 2026
Giulio2002
added a commit
that referenced
this pull request
Mar 2, 2026
…m field") Re-reverts #19508 to investigate regression in 'Sync from scratch test (minimal node)'. #19508 re-added SetTxNum() calls to exec3_serial.go, exec3_parallel.go, stage_execute.go, domain_shared.go and squeeze.go. These SetTxNum calls set sd.currentStep = txNum / stepSize during serial execution, which may corrupt state reads or commitment calculations at recent mainnet blocks (~24.5M). Bisect: mainnet PASSED at sha before #19508 (Feb 27), FAILED (gas used mismatch + wrong trie root) at sha after #19508 (Feb 28).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #19489
Lets do this in v3.5.0