[SharovBot] revert: Revert PR #19508 (Revert "[wip] sd: removing txNum field")#19564
Open
Giulio2002 wants to merge 1 commit intomainfrom
Open
[SharovBot] revert: Revert PR #19508 (Revert "[wip] sd: removing txNum field")#19564Giulio2002 wants to merge 1 commit intomainfrom
Giulio2002 wants to merge 1 commit intomainfrom
Conversation
…m field") Re-reverts #19508 to investigate regression in 'Sync from scratch test (minimal node)'. #19508 re-added SetTxNum() calls to exec3_serial.go, exec3_parallel.go, stage_execute.go, domain_shared.go and squeeze.go. These SetTxNum calls set sd.currentStep = txNum / stepSize during serial execution, which may corrupt state reads or commitment calculations at recent mainnet blocks (~24.5M). Bisect: mainnet PASSED at sha before #19508 (Feb 27), FAILED (gas used mismatch + wrong trie root) at sha after #19508 (Feb 28).
Giulio2002
requested review from
AskAlexSharov,
antonis19,
awskii,
mh0lt,
sudeepdino008,
taratorio and
yperbasis
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SharovBot]
Summary
Re-reverts #19508 to investigate a regression in the Sync from scratch test (minimal node).
Root Cause Investigation
Bisect of the failing CI run shows:
61e3808ea895, HEAD at time of run) → mainnet ✅ PASSED5d92478c9980, HEAD at time of run) → mainnet ❌ FAILED:gas used mismatch+Wrong trie rootat block ~24.5MPR #19508 falls squarely in the regression window (merged Feb 27 03:09 UTC). It is a partial revert of #19489 but adds new
SetTxNum()calls that were not in the original codebase before #19489:exec3_serial.go::executeBlock→se.doms.SetTxNum(txTask.TxNum)exec3_parallel.go→pe.doms.SetTxNum(applyResult.lastTxNum)stage_execute.go::unwindExec3State→sd.SetTxNum(txUnwindTo)domain_shared.go::SeekCommitment→sd.SetTxNum(txNum)SetTxNumsets bothsd.txNumANDsd.currentStep = txNum / stepSize. SettingcurrentStepto the live txNum (~6689 for mainnet block 24.5M) during serial execution may corrupt how snapshot file boundaries are evaluated during commitment or state reads.This PR
Reverts the changes introduced by #19508 so the sync-from-scratch test can be re-run on this branch to confirm/deny the hypothesis.
Testing
Triggering
QA - Sync from scratch (minimal node)on this branch.