collate: replace bitmap by array#19995
Merged
AskAlexSharov merged 12 commits intorelease/3.4from Mar 19, 2026
Merged
Conversation
AskAlexSharov
force-pushed
the
alex/collate_array_34
branch
from
50895ec to
3d0e3b7
Compare
sudeepdino008
approved these changes
Mar 19, 2026
AskAlexSharov
added a commit
that referenced
this pull request
Apr 12, 2026
replace bitmap by `u32` array. Because even with `bitmap32` use - still have much allocs in collate. And in worst case (all txnums of step N added to this array) - it's 1.5mb array. based on #19992 problem: <img width="1049" height="1174" alt="Screenshot 2026-03-19 at 11 54 15" src="https://github.com/user-attachments/assets/a0de9d6a-f9fc-46e8-8135-fb16b1d747e2" /> <img width="970" height="945" alt="Screenshot 2026-03-19 at 11 56 11" src="https://github.com/user-attachments/assets/5f88bf77-c84b-4c30-b6ec-a5b66cc248f5" />
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
Cherry-pick from `release/3.4` to `main`: - #19677 agg: workers presets. ressplit workers - #19919 Revert "flush: use etl.IdentityLoadFunc instead custom. part2" - #19780 etl: zero-copy memDataProvider - #19941 d_lru: disable for commitment - #19942 TemporalMemBatch: re-use vals-slice when can - #19996 etl: pool of bufwriter - #19995 collate: replace bitmap by array - #20002 skill creator review results - #20033 seg: revert global limiter - #20046 Caplin: prevent calling `glob` per file in `BuildMissingIndices` - #20113 seg: more usage of bufio - #20194 execution/state: revert CodeSizePath in codeChange journal entry - #20431 remove `flush complete` log line - #20440 etl: munmap temp files in Dispose to prevent disk space leak 93 commits skipped due to conflicts (branches diverged significantly). --------- Co-authored-by: lystopad <oleksandr.lystopad@erigon.tech> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: moskud <sudeepdino008@gmail.com> Co-authored-by: info@weblogix.biz <admin@10gbps.weblogix.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace bitmap by
u32array. Because even withbitmap32use - still have much allocs in collate. And in worst case (all txnums of step N added to this array) - it's 1.5mb array.based on #19992
problem:
