seg: more usage of bufio#20113
Merged
AskAlexSharov merged 2 commits intorelease/3.4from Mar 24, 2026
Merged
Conversation
![erigon-copilot[bot]](https://avatars.githubusercontent.com/in/3015145?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
[SharovBot]
LGTM. Three clean changes:
-
dataprovider.go—BufIOSize(=128*4096= 512 KB) → explicit512*datasize.KB. Identical value, just more readable. No behavioral change. -
compress.go— pool buffers 128 KB → 256 KB. Reasonable uplift for segment read/write throughput. -
parallel_compress.go—PersistDictionaryandReadSimpleFilenow use the package pool instead of allocating ad-hoc. Defer/cleanup ordering is correct:w.Flush()anddf.Sync()/df.Close()run beforeputBufioWriterfires.
Minor note: PersistDictionary's writer buffer shrinks from 2×BufIOSize = 1 MB → 256 KB (pool size). Dictionary building is infrequent so this is unlikely to matter in practice, but worth being aware of.
AskAlexSharov
added a commit
that referenced
this pull request
Apr 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
Cherry-pick from `release/3.4` to `main`: - #19677 agg: workers presets. ressplit workers - #19919 Revert "flush: use etl.IdentityLoadFunc instead custom. part2" - #19780 etl: zero-copy memDataProvider - #19941 d_lru: disable for commitment - #19942 TemporalMemBatch: re-use vals-slice when can - #19996 etl: pool of bufwriter - #19995 collate: replace bitmap by array - #20002 skill creator review results - #20033 seg: revert global limiter - #20046 Caplin: prevent calling `glob` per file in `BuildMissingIndices` - #20113 seg: more usage of bufio - #20194 execution/state: revert CodeSizePath in codeChange journal entry - #20431 remove `flush complete` log line - #20440 etl: munmap temp files in Dispose to prevent disk space leak 93 commits skipped due to conflicts (branches diverged significantly). --------- Co-authored-by: lystopad <oleksandr.lystopad@erigon.tech> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: moskud <sudeepdino008@gmail.com> Co-authored-by: info@weblogix.biz <admin@10gbps.weblogix.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.