rpc/jsonrpc: close getProof's SharedDomains - #22210
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a resource leak in the JSON-RPC eth_getProof implementation by ensuring the SharedDomains instance created for proof computation is always closed, matching the existing pattern used by the sibling witness path.
Changes:
- Add
defer domains.Close()ingetProofafter successfulexecctx.NewSharedDomains(...)creation to prevent per-call leaks of the mem batch and commitment context.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
awskii
approved these changes
Jul 3, 2026
awskii
enabled auto-merge
July 3, 2026 10:49
lupin012
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getProofcreates aSharedDomainsfor its proof computation and never closes it on any path, leaking the SD's mem batch and commitment trie context on everyeth_getProofcall. The siblinggetWitnessalready doesdefer domains.Close().Found during the review of #22198.
No red test: a missing
defer Closehas no practical unit-level repro (the leak only shows as memory growth across many calls), so this is a mechanical consistency fix mirroring the adjacentgetWitnesspattern.