qa-tests: add Claude's skills to improve the analysis of QA test results. - #22769
Merged
mriccobene merged 7 commits intoJul 30, 2026
Merged
Conversation
mriccobene
marked this pull request as ready for review
July 28, 2026 10:44
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new .claude skill (qa-test-results) that documents how to interpret Erigon’s long-running QA GitHub Actions workflows (sync/tip-tracking, snapshot download, clean exit, and RPC integration/performance), with concrete triage steps and per-workflow reference material.
Changes:
- Introduces a
qa-test-resultsClaude skill with a “cheapest signal first” triage flow and key failure-mode explanations. - Adds reference docs covering workflow families/artifacts, a triage decision tree, and detailed log-reading guides for sync and RPC QA suites.
- Documents the structure/meaning of
result-<chain>.jsonand how to use it to interpret outcomes and measures.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .claude/skills/qa-test-results/SKILL.md | Main skill guide for reading QA logs/results and interpreting common failure causes. |
| .claude/skills/qa-test-results/references/workflows.md | Maps qa-* workflows to runner labels, drivers, artifacts, and where verdicts live. |
| .claude/skills/qa-test-results/references/triage.md | Step-by-step decision tree for diagnosing red QA checks from cheapest signals upward. |
| .claude/skills/qa-test-results/references/sync-tests.md | Field-by-field explanation of sync/tip-tracking report blocks and metrics. |
| .claude/skills/qa-test-results/references/rpc-tests.md | Explains RPC integration vs performance log formats and where pass/fail is determined. |
| .claude/skills/qa-test-results/references/result-json.md | Defines the schema/meaning of result-<chain>.json, outcomes, reasons, and measures. |
Comments suppressed due to low confidence (1)
.claude/skills/qa-test-results/SKILL.md:229
- This references a root
CLAUDE.md, but there is noCLAUDE.mdat the repository root; the test-skip policy lives inAGENTS.md(see the "Test skips" section). As written, the link/filename will send readers to a non-existent file.
`batch processing with #blocks=N` and `head updated with age=N` are the
breadcrumbs that explain a sync-time failure.
- **Never propose muting or skipping a QA test** to get a check green; see the
project's test-skip policy in `CLAUDE.md`.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AskAlexSharov
approved these changes
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
AskAlexSharov
enabled auto-merge
July 29, 2026 10:20
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mriccobene
enabled auto-merge
July 30, 2026 08:21
mriccobene
deleted the
qa-tests/add-claude-skill-for-qa-test-result-analysis
branch
July 30, 2026 10:11
Member
|
for future, can also add a symlink reference for codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.