drop the BlockStateCache from calcFees/finalize (P4) - #23207
Draft
sudeepdino008 wants to merge 1 commit into
Draft
drop the BlockStateCache from calcFees/finalize (P4)#23207sudeepdino008 wants to merge 1 commit into
sudeepdino008 wants to merge 1 commit into
Conversation
…inalize base reader (#23140)
sudeepdino008
changed the title
sudeepdino008
changed the title
sudeepdino008
changed the title
sudeepdino008
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-tx
calcFeesand block-finalize steps share one basestateReader. It usesBlockStateCache(specifically, thecurrentfields) as fallback, because the versionMap was not a strict superset of the buffer (there was a case of EIP-161 clearing accounts)But #23149 fixes this...such that versionMap truly carried the in-block accumulated writes properly. This allows us to use versionMap for the stateReader, and remove BlockStateCache here.
NewHistoryReaderV3WithSharedDomains(was...WithBlockCache)NewReaderV3(wasNewCurrentCachedReaderV3)Verified: mainnet re-exec through block 2,676,607 (the EIP-161 sweep block that previously surfaced a wrong trie root) → 0 wrong roots.
Stacked on #23171.