Collapse CI's Lite fast / analysis-heavy test split into one step - #1701
Merged
Conversation
The split existed because the seven analysis classes rebuilt the full DuckDB schema inside every test and their subset alone cost ~9 CI minutes, so a narrower lite_analysis path gate let non-analysis Lite changes skip it. After the shared class fixtures (#1693, #1698) and batched seeding (#1694), that subset runs in ~66s on the same runner - the split no longer earns its second test-host spin-up, and the hand-maintained class-name filters were a drift risk (a renamed class would silently fall out of the heavy filter and into fast). One "Run Lite tests" step now runs the whole suite, gated on the lite path filter; the unconsumed lite_analysis filter block is removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1693 / #1694 / #1698, previously flagged and now approved: with the analysis-heavy subset down from 556-612s to ~66s on the CI runner, the fast/heavy split no longer earns its keep. One Run Lite tests step now runs the whole suite.
Why the split is safe to remove
litepath filter (Lite/**+Lite.Tests/**) is a strict superset oflite_analysis, so the heavy step could never run without the fast step also running - the split's only value was letting non-analysis Lite changes SKIP the heavy subset. That was worth it at 9 minutes; it is not at 66 seconds.The unconsumed
lite_analysisfilter block is removed. This PR's own CI run executes the new workflow, so the collapsed step validates itself - its "Run Lite tests" duration should land around 2-2.5 minutes.Generated with Claude Code