State the rule that decides how a new AG measure gets handled (#991) - #1710
Merged
Conversation
The doc block ended up carrying two superficially similar measures with
OPPOSITE prescriptions - gate drain-time, never use commit deltas - and no
stated reason for the difference. That is the setup for someone adding a new AG
measure and picking whichever precedent they read first.
ag-fixture-builder named the discriminator while closing out their own file, and
it is the right one: the failure DIRECTION, not the column.
fails in ONE direction -> GATE it. The may-fire-never-clear rule
neutralizes it, because the direction it
suppresses is exactly the one that would clear an
alarm wrongly.
fails in BOTH directions -> DO NOT USE IT. No directional gate helps:
under different conditions suppressing the reassuring half leaves the
false-alarm half, so gating converts a silent
failure into a noisy one rather than a correct
one.
That is why drain-time got gated and commit deltas got banned, and now the file
says so instead of leaving it as two special cases to be pattern-matched.
Also recorded, because it is the transferable part: every measured VALUE in this
area moved at least once during the work - MS Learn's documented lag behavior,
the latch timing, the drain estimate, the lag baseline under load versus idle -
while the direction-based rules never moved once. When the underlying behavior
is documented wrong and the measurements are load-dependent, reason about which
way a reading can lie rather than about its magnitude. Direction is what
survives the numbers being wrong, and in this file the numbers were wrong
repeatedly, mine included.
Documentation only, no logic change.
Darling suite green: 3252 passed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
erikdarlingdata
added a commit
that referenced
this pull request
Jul 26, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
erikdarlingdata
enabled auto-merge
July 26, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last one on this thread. Doc-only, no logic change.
The gap
The AG sync doc block ended up carrying two superficially similar measures with opposite prescriptions — gate drain-time (#1703), never use commit deltas (#1708) — and no stated reason for the difference. That is the setup for someone adding a new AG measure and picking whichever precedent they happened to read first.
The discriminator
ag-fixture-builder named it while closing out their own evidence file, and it is the right one: the failure direction, not the column.
That is why drain-time got gated and commit deltas got banned. The file now says so, instead of leaving two special cases to be pattern-matched.
The transferable part
Every measured value in this area moved at least once during the work — MS Learn's documented lag behavior, the latch timing, the drain estimate, the lag baseline under load versus idle — while the direction-based rules never moved once. When the underlying behavior is documented wrong and the measurements are load-dependent, reason about which way a reading can lie rather than about its magnitude. Direction is what survives the numbers being wrong, and in this file the numbers were wrong repeatedly, mine included.
Testing
Darling suite green: 3252 passed, 0 failed.
🤖 Generated with Claude Code