Recompress verb: state the measured lock window, not 'typically minutes' - #2079
Conversation
The reference compaction (174 GB dimension, 7.1M plans -> 77 GB) held its exclusive lock for ~46 minutes, during which collection freshness degraded to 15/52 and recovered fully within five minutes of release. 'Typically minutes' was a guess the measurement contradicts; the verb output, dry-run text, and CHANGELOG now carry the measured number and tell operators to scale by their dimension. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| output.WriteLine(" free disk. Size the lock window by your dimension: measured ~46 minutes on a 174 GB"); | ||
| output.WriteLine(" dimension (7.1M plans), during which collection freshness DEGRADES and recovers within"); | ||
| output.WriteLine(" minutes after. --no-vacuum-full skips it to schedule that window separately."); |
There was a problem hiding this comment.
Nit: this PR's whole point is to replace a vague guess ("typically minutes") with the measured number, and it does that for the lock duration (~46 minutes). But the recovery time reverts to the same kind of vague qualifier it just eliminated — "recovers within minutes after" — even though the measured figure is known and precise ("within five minutes of release," per the CHANGELOG and PR description). Worth using "five minutes" here too for consistency with the CHANGELOG entry below and the stated goal of this change.
| output.WriteLine(" This takes an EXCLUSIVE lock on the plan dimension — collections DEGRADE until it"); | ||
| output.WriteLine(" finishes and recover within minutes after (measured: ~46 minutes of lock on a 174 GB"); | ||
| output.WriteLine(" dimension; scale by yours). The service does not need to stop."); |
There was a problem hiding this comment.
Same nit as the dry-run message above: "recover within minutes after" is vague, but the CHANGELOG states the measured recovery was "within five minutes." Since this PR's purpose is to state measured numbers instead of guesses, consider using the precise figure here too, for consistency between the two CLI output sites and the CHANGELOG.
|
Reviewed. This is a small, low-risk change: two
Left two inline nits: both new CLI messages say recovery "recovers within minutes after," which is the same kind of vague qualifier this PR set out to replace — the CHANGELOG and PR description both give the precise measured figure ("within five minutes"). Worth using that number in the CLI text too for consistency, since precision-over-guessing is the whole point of this PR. |
1 participant
The reference compaction on the production store measured ~46 minutes of exclusive lock for a 174 GB dimension (7.1M plans → 77 GB), with collection freshness degraded (15/52) for the duration and full recovery within five minutes of release. The shipped text said "typically minutes" — a guess the measurement contradicts. Verb output, dry-run disclosure, and CHANGELOG now carry the measured number and tell operators to scale by their own dimension size.
🤖 Generated with Claude Code