Skip to content

Version 3.4.0 - #2083

Merged
erikdarlingdata merged 1 commit into
devfrom
version-3.4.0
Aug 6, 2026
Merged

Version 3.4.0#2083
erikdarlingdata merged 1 commit into
devfrom
version-3.4.0

Conversation

@erikdarlingdata

Copy link
Copy Markdown
Owner

Bumps the three shipped csprojs (Lite, Darling Service, Darling Viewer) 3.3.0 → 3.4.0 and retitles the CHANGELOG's Unreleased section to ## [3.4.0] - 2026-08-06. No code changes. The only 3.3.0 references outside csprojs are generated obj/ files.

🤖 Generated with Claude Code

Bumps the three shipped csprojs and retitles the CHANGELOG's Unreleased
section. Headlines of this release: gzip plan-dimension storage (V54,
14.4x measured on 885 GB of production plans) with the
--recompress-plan-dim operator verb (verified conversion + VACUUM FULL
compaction, both validated end-to-end on the 52-replica store), store
self-metrics (V53), Lite Query Store backfill, persisted finding
drill-downs (V52), Azure SQL DB support for the backfill worker, stable
releases shipping signed Linux artifacts (Sigstore + SLSA provenance),
and the configure-network comma-splice fix.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment on lines 12 to 14
<AssemblyVersion>3.3.0.0</AssemblyVersion>
<FileVersion>3.3.0.0</FileVersion>
<InformationalVersion>3.3.0</InformationalVersion>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bumped to 3.4.0 but AssemblyVersion, FileVersion, and InformationalVersion are left at 3.3.0/3.3.0.0. This isn't cosmetic: UpdateCheckService.GetCurrentVersion() reads Assembly.GetEntryAssembly()?.GetName().Version, which comes from AssemblyVersion, not Version. After this release ships as tag v3.4.0, a user running the 3.4.0 build will still report 3.3.0.0 and the update checker will keep telling them a new version is available. The About window and ManageServersWindow (which read InformationalVersion, falling back to AssemblyVersion) will also keep showing 3.3.0. Please bump all four fields together.

Comment on lines 9 to 10
<AssemblyVersion>3.3.0.0</AssemblyVersion>
<FileVersion>3.3.0.0</FileVersion>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as the Lite csproj: Version moved to 3.4.0 but AssemblyVersion/FileVersion are still 3.3.0.0. App.xaml.cs's startup log (Assembly.GetExecutingAssembly().GetName().Version) and the entry-assembly read in UpdateCheckService.GetCurrentVersion() both resolve from AssemblyVersion, so the shipped 3.4.0 build will still self-report as 3.3.0.0 at runtime and in update checks.

Comment on lines 19 to 20
<AssemblyVersion>3.3.0.0</AssemblyVersion>
<FileVersion>3.3.0.0</FileVersion>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as the other two csprojs in this PR: AssemblyVersion/FileVersion weren't bumped alongside Version. AboutWindow.xaml.cs reads Assembly.GetExecutingAssembly().GetName().Version directly (i.e. AssemblyVersion), so the Viewer's About dialog will keep showing 3.3.0.0 after this ships as 3.4.0.

@claude

claude Bot commented Aug 6, 2026

Copy link
Copy Markdown

Reviewed. This is a small, mechanical PR (version bump + CHANGELOG retitle, no logic changes), and the CHANGELOG edit itself is correct and consistent with the existing "Keep a Changelog" section pattern used in this file.

One real bug, same shape in all three touched csproj files: each bumps <Version> from 3.3.0 → 3.4.0 but leaves <AssemblyVersion>/<FileVersion> (and, in Lite, <InformationalVersion>) at 3.3.0/3.3.0.0. Left inline comments on each file with the specifics, but the shared consequence: Assembly.Get(Entry|Executing)Assembly().GetName().Version reads AssemblyVersion, not Version. That's what UpdateCheckService.GetCurrentVersion(), the Lite/Darling Viewer About windows, and both apps' startup log lines all use — so binaries built from this PR will keep self-reporting 3.3.0.0 at runtime, and the update checker will keep nagging users who are already on 3.4.0 that an update is available. This affects Lite and Darling identically (not a parity drift between them, just a shared miss), so it needs to be fixed in all three files together.

No security, correctness, or Lite/Darling parity issues beyond that — nothing else in the diff to flag.

@erikdarlingdata
erikdarlingdata merged commit 10f9380 into dev Aug 6, 2026
5 checks passed
@erikdarlingdata
erikdarlingdata deleted the version-3.4.0 branch August 6, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant