Fix Lite SnoozeBalloon dismiss/snooze buttons being no-ops#993
Merged
Conversation
SnoozeBalloon.CloseBalloon() raised TaskbarIcon.BalloonClosingEvent and assumed the library would tear the popup down. Hardcodet emits that event when it closes a popup; it has no listener that translates a balloon-initiated raise back into a close, so user-initiated dismiss did nothing and the popup persisted until the next refresh tick replaced it. Pass an Action closePopup callback that invokes TaskbarIcon.CloseBalloon() directly, the same method the library uses for timeout-based and replacement-based closes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #992
Summary
SnoozeBalloon.CloseBalloon()was raisingTaskbarIcon.BalloonClosingEventexpecting the library to close the popup. Hardcodet only emits that event during its own close path; it has no listener that converts a balloon-initiated raise into a close. So user dismiss/snooze clicks did nothing.Action closePopuptoSnoozeBalloonthat invokesTaskbarIcon.CloseBalloon()directly — the same method used internally for timeout and replacement closes.Test plan
dev: HammerDB driving sql2025 triggered Blocking Detected / Deadlocks Detected popups; clicking Dismiss did nothing across 400+ clicks on the same popup.CloseBalloon()).🤖 Generated with Claude Code