Bring Dashboard alert toasts to parity with Lite#995
Merged
Conversation
Replace Dashboard's native ShowBalloonTip popups with the snoozable custom WPF popup from Lite. Adds Snooze 15m / 1h / 4h and Dismiss buttons that create temporary mute rules via the existing MuteRuleService — no new persistence; the rule management UI in Settings already shows them. - Port SnoozeBalloon control (XAML + code-behind) to Dashboard/Controls, preserving the close-callback fix from #993 so user-initiated dismiss actually tears the popup down - Add NotificationService.ShowSnoozableNotification, mirrored after Lite's SystemTrayService.ShowSnoozableNotification - Switch the 7 actionable alert sites in MainWindow (Blocking, Deadlock, HighCpu, PoisonWait, LongRunningQuery, TempDbSpace, LongRunningJob) to the snoozable popup, passing each metric's existing AlertMuteContext name so popup-created snoozes match alert-site mute lookups - Remove the 7 typed ShowXxxNotification wrappers — their per-metric prefs.NotifyOnXxx guards are already enforced at the alert sites - Connection-state notifications (Server Online / Offline / Restored) stay as native ShowBalloonTip — Action Center is the right home for those Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #994
Summary
ShowBalloonTiptoasts with the dark-themed, snoozable custom popup ported from Lite.MuteRulevia the existingMuteRuleService— the rule shows up in Settings → Manage Mute Rules alongside any user-created rules.NotificationService; per-metricprefs.NotifyOnXxxguards already live at the alert sites.ShowBalloonTip— those route to Windows Action Center, which is the right home for transient connectivity events.Test plan
ManageMuteRulesWindow, suppresses further alerts for that server+metric for 15 min, leaves other metrics on the same server firingDynamicResource)🤖 Generated with Claude Code