Fix #283: columnstore icon routing + Parallelism subtype overlay#285
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 26, 2026
Merged
Fix #283: columnstore icon routing + Parallelism subtype overlay#285erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
…r Parallelism subtypes Columnstore: PhysicalOp surfaces as "Clustered Index Scan" / "Index Scan" / "Columnstore Index Scan" with Storage="ColumnStore" on the Object element. The mapper previously only inspected PhysicalOp, leaving the columnstore_* icons unused. PlanIconMapper.GetIconName now takes an optional storageType and routes to the columnstore variant when Storage="ColumnStore". Covers both clustered (CCI) and nonclustered (NCCI) columnstore for scan, delete, insert, update, and merge. Parallelism (Repartition / Distribute / Gather Streams): all three share PhysicalOp="Parallelism" and the same parallelism.png icon. Following the overlay approach used by microsoft/vscode-mssql, render a small R/D/G glyph in the bottom-right corner of the icon to distinguish them at a glance. LogicalOp determines the letter; non-parallelism nodes get no overlay. Closes #283. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 26, 2026
Merged
erikdarlingdata
added a commit
that referenced
this pull request
Apr 27, 2026
Highlights since v1.8.0: - Minimap for plan navigation (#276) - Colored links by accuracy ratio divergence (#289) - Distinct parallelism subtype icons (#285, #288) - Query Store filter ordering fix (#287) - xunit v2 -> v3 migration (#278) - SqlClient 6 -> 7, ScriptDom 170 -> 180 (#279) - System.CommandLine GA (#280) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283.
Summary
PhysicalOpsurfaces asClustered Index Scan/Index Scan/Columnstore Index ScanwithStorage="ColumnStore"on the Object element.PlanIconMapper.GetIconNamenow accepts an optionalstorageTypeand routes to the columnstore variant when applicable. Covers both CCI and NCCI for scan/delete/insert/update/merge. The columnstore icons were already inResources/PlanIcons/, just unused.PhysicalOp="Parallelism"and a singleparallelism.png. Following the overlay techniquemicrosoft/vscode-mssqluses for parallel-execution markers, we render a small R/D/G glyph in the corner of the icon to distinguish them. No new icon assets — sourcing distinct subtype icons would have meant licensing assets we don't have rights to.Test plan
🤖 Generated with Claude Code