erts: Fix missing exit_status caused by SIGCHLD race - #11285
Open
garazdawi wants to merge 1 commit into
Open
Conversation
Consider this scenario: 1. Read FD signals EOF 2. ready_input called and read returns 0 3. call port_inp_failure, wait for SigChld 4. spawn_control called with SigChld, triggering driver_select on read fd 5. ready_input called again and now exit_status is delivered Not all OSs actually trigger a second poll signal when we re-select on an FD has already signaled EOF. So if that trigger never happens then step 5 is left out and no exit_status is delivered. closes erlang#11278
Contributor
CT Test Results 3 files 136 suites 52m 45s ⏱️ For more details on these failures, see this check. Results for commit a42731d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
This was referenced Jun 24, 2026
Member
Author
|
For Erlang/OTP 28 and later, this PR is superseded by #11298. |
lucioleKi
added
the
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider this scenario:
Not all OSs actually trigger a second poll signal when we re-select on an FD has already signaled EOF. So if that trigger never happens then step 5 is left out and no exit_status is delivered.
closes #11278