Add config option to set a custom Sentry Transport #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
Author
Contributor
|
+1 on needing this. We'll have to fork errbot to work with our internal sentry without this change |
Member
|
Awesome, can you add it to the config sample and the doc at the same time so people can discover that more easily? Thanks |
Contributor
Author
|
@gbin Totally! Will get on that. Thanks! |
Contributor
Author
|
@gbin Added docs and config-sample for your approval/merge. |
gbin-argo
approved these changes
Jan 24, 2018
Contributor
Author
|
@gbin-argo I am unable to merge, not sure if that is intentional or if you were just staging changes for a release
|
gbin
approved these changes
Feb 24, 2018
gbin-argo
pushed a commit
that referenced
this pull request
May 15, 2018
* Add config option to set a custom Sentry Transport * Document new config option for custom Sentry Transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue the other day where I needed to set a custom Sentry Transport and was unable to. This is a first pass at how this might work. The implementation is a bit complex due to the need to dynamically import the transport class from raven, based on the configured transport provided by the user.
List of transports and their classes can be found here: https://docs.sentry.io/clients/python/transports/
Example config option would be:
SENTRY_TRANSPORT = ('RequestsHTTPTransport', 'raven.transport.requests')