Cannot invoke `Uint8Array.prototype.toBase64` in browsers because `typed-array-byte-offset` is not browser-safe

[andy0130tw]

Basically I stumbled upon this issue:

inspect-js/typed-array-byte-offset#2

Some implementations like Uint8Array.prototype.toBase64 depends on your npm library typed-array-byte-offset. It crashes in the browsers because there are references to variable name global that is only meaningful in Node.js, not in browsers.

From the above issue being closed as not planned, can I say that the library is not browser-safe? And from the readme of this library, one usage of this library is to fix Safari's incorrect behavior. To allow using this library to polyfill all provided functions in browsers (hopefully without bundlers), I suggest inlining the code from that library into this and changing global to globalThis.

[ljharb]

That should be fine, since any properly functioning node module bundler transforms global to window (or globalThis). In other words, this library is absolutely browser-safe.

[andy0130tw]

The problem is, why use bundlers to workaround the non-standard global when you can simply change the code? Node.js and browsers both understand globalThis, which you should prioritize if this package is intended for the web.

[ljharb]

You need to use a bundler regardless, and we support both node and browser versions that don't understand globalThis.