Unify CLI config-failure exit codes via a single ConfigError catch#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config-resolution failures had two inconsistent conventions: non-interactive paths called
sys.exit(codes.CONFIG), while interactive paths (--profile,--cli, manual prompts) and the--config <bad file>path justreturned - meaning the process exited 0 on those failures. A CLI that exits 0 on failure silently breaks any script wrapping it (set -e,&&,$?checks).This PR routes every config failure through the
ConfigErrorseam introduced in the config-resolution refactor (#50) and maps it to an exit code in exactly one place.What changed
handle_aws/handle_azure: the--config-file failure now raisesConfigErrorinstead ofreturning, and all six per-branchtry/except ConfigErrorblocks were removed — resolvers now propagate freely.main(): a singleexcept ConfigError: sys.exit(codes.CONFIG)wraps theprovider dispatch, so file and credential failures — interactive or not — all
exit
2from one choke point.