fix(plugin): support marketplace preflight without Windows console flashes / 支持市场预检并消除 Windows 黑框#6405
Merged
SivanCola merged 3 commits intoJul 13, 2026
Conversation
Plan and install relative-path Claude marketplace entries from one pinned GitHub snapshot. Route plugin Git subprocesses through the Windows hidden-window helper and cover marketplace selection, validation, cleanup, and real install behavior.
github-actions
Bot
added
the
v2
Real Claude marketplaces spell relative plugin sources both as ./plugins/example and as the bare plugins/example; the preflight now accepts both (absolute and drive-qualified paths are still rejected before the join, and escape attempts still fail the plan loudly). Entries the subset cannot install — object sources, external URLs, and invalid plugin names — no longer fail the whole marketplace plan: bulk installs skip them with a per-entry warning, while selecting such an entry by name reports a precise error. Names are validated at plan time so broken entries surface in the preview instead of mid-apply. Also pins the planId approval contract for marketplaces: the preview planId must match the planId recomputed by the apply call.
The desktop app hosts bot bridges in the GUI process; the project search rg subprocess was the one remaining child in that path spawned without the hidden-window flags, flashing a console on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./plugins/exampleand bareplugins/examplerelative sources; entries the subset cannot install (object sources, external URLs, invalid plugin names) skip with a per-entry warning during bulk installs and report a precise error when selected by nameVerification
go test ./internal/installsource ./internal/bot ./internal/pluginpkg ./internal/procgo vet ./internal/installsource ./internal/bot ./internal/pluginpkgDEEPSEEK_API_KEY= go test ./...cd desktop && go test ./...GOOS=windows GOARCH=amd64 go test -c -o /tmp/reasonix-installsource-windows.test.exe ./internal/installsourceGOOS=windows GOARCH=amd64 go build ./internal/installsource ./internal/botCSlawyer1985/claude-for-legal-ZH: 12 plugin actions and 150 skills planned from one pinned commitCache impact
Cache-impact: low - changes
install_sourceplugin discovery, desktop child-process behavior, and bot search child-process flags only; provider-visible tool schemas, system prompts, memory prefixes, and request serialization are unchanged.Cache-guard: focused install-source/plugin-package/bot tests, full root tests, desktop tests, and Windows target compilation passed.
System-prompt-review: N/A