fix(cards): restore brand accent on done-state assistant reply#140
Merged
fix(cards): restore brand accent on done-state assistant reply#140
Conversation
PR #126 (0.23.0) gave done assistant Markdown a brand-toned borderLeft per lamyc's RFC #20 readability ask. The #136 card redesign extracted CardBox but flipped the done-state color to FG.faint, defeating the contrast that lets long replies stand out in scrollback. Now matches the streaming-state color so the bar reads continuously across the streaming → done flip. Aborted state stays on FG.faint (correctly de-emphasized).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #126 (0.23.0) shipped a brand-toned
borderLeftaccent on done assistant Markdown — explicitly responding to lamyc's RFC #20 ask: "Model response readability — A background highlight on responses (instead of just text color) would make long replies much easier to follow."PR #136 (0.23.1) refactored reasoning + streaming cards onto the shared
CardBoxprimitive. In that refactor, the done-state color was changed from the brand tone toFG.faint(#484f58, dim grey). The bar is still technically there, but it's so muted it doesn't deliver the contrast that #126 was designed to provide — long replies blend into surrounding scrollback again.This restores the done state to
CARD.streaming.color(=TONE.brand,#79c0ff), matching the streaming state. The bar now reads continuously across the streaming → done flip.Aborted state stays on
FG.faint(correctly de-emphasized — that part of #136 was right).Diff
One line in
src/cli/ui/cards/StreamingCard.tsx:if (card.done && !card.aborted) { return ( - <CardBox color={FG.faint}> + <CardBox color={CARD.streaming.color}>Test plan
npm run verify— 1824/1824 tests passOut of scope
CardBox(separate change — currently onlyStreamingCardandReasoningCarduse it)<Text backgroundColor>wrapping, separate RFCRefs