fix(cards): drop fake key hints + CtxCard CardHeader + TaskCard meta tidy#145
Merged
fix(cards): drop fake key hints + CtxCard CardHeader + TaskCard meta tidy#145
Conversation
…tidy Plan + Error cards advertised inline keybinds in their footers (`[r] revise` / `[r] retry` etc.) but no handler was ever wired to scrollback cards — the actual revise/retry flow runs through PlanConfirm modals via arrow + Enter. Pressing the advertised key did nothing. Removed the misleading footers; the modal flows are unchanged. CtxCard hand-rolled its own header instead of using CardHeader, breaking the visual contract every other card follows. Routed it through CardHeader with the same tone/glyph/meta shape. TaskCard's `meta` ended in a trailing space (`X.Xs · `) and CardHeader inserts its own space before the trailing badge, so the rendered output had a double space before the status word. Also collapsed a dead ternary branch in PlanCard step-color logic where two arms produced the same value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Card-stream polish from a full audit of the 14 non-polished cards. Four targeted fixes:
A. Drop misleading inline keybind hints
PlanCardandErrorCardadvertised inline keys in their footers but no handler was ever wired to scrollback cards. The actual flows go through modal pickers (PlanConfirmfor revise/skip, prompt-loop for retry).PlanCard.tsx:27—[r] revise [s] skip step [↵] expand item— removed footer + the constantErrorCard.tsx:51-57—[r] retry [s] skip— removed footerAffordance contract: if a key is shown, it must work. These didn't, so they go.
B. CtxCard → CardHeader
CtxCard.tsx:30-37hand-rolled a header (raw<Box>+<Text>with manual indent + custom glyph color) instead of using the sharedCardHeaderprimitive every other card uses. Routed throughCardHeaderwithtone="usage"and the existing⌘glyph; rendered output is visually identical, but consistency contract restored.C. TaskCard meta double-space
TaskCard.tsx:44—meta={${elapsed} ·}(trailing space).CardHeaderalready inserts a space before the trailing badge, producingX.Xs · done(double space). Trimmed to${elapsed} ·.D. Dead ternary branch in PlanCard
PlanCard.tsx:42hadisActive ? FG.strong : step.status === "queued" ? FG.sub : FG.sub— both inner arms identical. Collapsed toisActive ? FG.strong : FG.sub.Test plan
npm run verify— 1829/1829 tests passOut of scope (deferred from audit)
tone="streaming"(cosmetic naming only — colors are equivalent)elisionHint(count, kind)util refactor)<ProgressBar>primitive)Pillbadges to ErrorCard / WarnCard (would dilute the live-activity-card visual language)Refs