chore: add allowScripts field to package.json#489
Merged
Conversation
|
|
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lumirlumir
requested changes
Jul 19, 2026
Co-authored-by: lumir <yonghyeon0324@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Add the
allowScriptsfield topackage.jsonfor the npm install scripts policy, following the same approach as the PR for eslint/eslint.What changes did you make? (Give an overview)
Starting with npm 12, install scripts that aren't covered by
allowScriptsare blocked by default. On a fresh install, three packages are blocked:yorkieandfsevents(×2, macOS-only).This PR allows only
yorkie, since it's the only one whose install script is actually required — it installs the git hooks, so when it's blocked thepre-commithook is never created andlint-stagedno longer runs on commit.fseventsis intentionally left out: its install script isn't required, and the module still loads and works correctly without it.I left the entry unpinned (
"yorkie": true) since this repository commitspackage-lock.json, so the version is already locked. I'd be happy to pin it if reviewers prefer.Related Issues
Is there anything you'd like reviewers to focus on?
Verified on npm 12.0.1 / Node.js v24.18.0 (
rm -rf node_modules && npm install):allowScripts,yorkieis blocked and.git/hooks/pre-commitis missing."yorkie": true,yorkieruns and the hook is created.fseventsloads correctly even while its install script stays blocked.I'd appreciate any feedback on whether
fseventsshould be handled explicitly, and on the unpinned-vs-pinned decision.