fix: remove unsupported nodeType from types - #268
Merged
Conversation
mdjermanovic
approved these changes
Sep 10, 2025
mdjermanovic
left a comment
mdjermanovic
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! Would like another review before merging.
fasttime
approved these changes
Sep 10, 2025
fasttime
left a comment
fasttime
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! I verified that the type integration tests in the main repo are passing with this change.
github-project-automation
Bot
moved this from Second Review Needed
to Complete
in Triage
Merged
1 task
snitin315
pushed a commit
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR removes
nodeTypefromViolationReportBase.context.report()doesn’t accept anodeTypeproperty—it is ignored.Related Issues
Is there anything you'd like reviewers to focus on?