Conversation
|
@patdunlavey can you please give this a check? |
…perations in AmiUtilityService::preprocessAmiSet and AmiUtilityService::getProcessedAmiSetNodeUUids. Fixes cases where the process is executing under cron or hydroponics and the user is anonymous. (#215)
| } | ||
| if ($file && $data!== new \stdClass()) { | ||
| // Only UUIDs you can delete will be added. | ||
| $data->info['uid'] = $this->currentUser()->id(); |
There was a problem hiding this comment.
The ami set has a uid value - the author of the set. I'm not sure which uid makes more sense: the author of the ami set, or the user currently processing the set?
There was a problem hiding this comment.
The user processing in my opinion ... At least that has been the behavior. If we want to change that we can introduce a new feature/option in the future.
There was a problem hiding this comment.
That works for me - just wanted to make sure it was considered!
I have an AMI set processing (successfully - no white screen) on my local now. After that, I'll test deleting processed ADOs.
There was a problem hiding this comment.
@DiegoPino CONFIRMED: both processing and deleting processed ADOs are successful!
There was a problem hiding this comment.
I also checked that enqueued csv expansion and ado processing still work, and they do.
patdunlavey
left a comment
patdunlavey
left a comment
There was a problem hiding this comment.
Confirmed in local testing
|
Do you need a PR to get this merged to 0.9.0? |
…ons (#218) * Ensures info['uid'] to be present for both CSV expander and direct processing * Also for delete operation
2 participants
See #217