perf(ui): use ranged extmarks for line highlights - #461
Merged
esmuellert merged 2 commits intoJul 22, 2026
Conversation
richardgill
marked this pull request as ready for review
July 20, 2026 14:55
Collaborator
Author
|
@esmuellert PR build failed. I think this is the fix #462 |
esmuellert
added a commit
that referenced
this pull request
Jul 22, 2026
- Fixes the [Windows CI failure in #461](https://github.com/esmuellert/codediff.nvim/actions/runs/29659694570/job/88489171079): CodeDiff tries to load `/libvscode_diff_nil.dll`. - Current Neovim nightly can mishandle repeated `:h` modifiers on relative `./lua/...` paths after [neovim#40447](neovim/neovim#40447), resolving the plugin root to `/` and leaving `VERSION` nil. See [neovim#40545](neovim/neovim#40545). - Make the module source absolute with `:p` before traversing parents, and reuse that root for VERSION loading. - Verified on [Windows x64 and ARM64 CI](https://github.com/richardgill/codediff.nvim/actions/runs/29828651463).
…to perf-ranged-line-extmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace per-line highlight extmarks with one ranged extmark for each contiguous changed range.
This reduces Neovim API calls and extmark objects while preserving highlight groups,
hl_eol, priority, character-level highlights, and filler behavior.Performance
Validated against the existing prototype benchmark:
Sparse and isolated single-line changes are effectively unchanged.