Skip to content

feat(translator): use the shiny new rewritten GoBGP Protobufs and upgrade GoBGP - #241

Merged
crankynetmaam merged 1 commit into
mainfrom
topic/fern/gobgp-v4
Aug 11, 2026
Merged

feat(translator): use the shiny new rewritten GoBGP Protobufs and upgrade GoBGP#241
crankynetmaam merged 1 commit into
mainfrom
topic/fern/gobgp-v4

Conversation

@crankynetmaam

@crankynetmaam crankynetmaam commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

This upgrades us to the latest GoBGP version and uses the new protobufs (yay!) so we don't have to do the annoying manual packing of attributes.

Closes #212 and I think #214 because I'm happy (enough) with how this actually handles generating things with a real honest to god useful protobuf. It's at least more functional (and we just touch a init.py to seal the deal towards packagifying the grpc code. )

@github-actions

Copy link
Copy Markdown

Scheduler Coverage

File Coverage
All files 100%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 379c7ba

@github-actions

Copy link
Copy Markdown

Scripts Coverage

File Coverage
All files 50%
scripts/extract_env_vars.py 50%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 379c7ba

@github-actions

Copy link
Copy Markdown

Translator Coverage

File Coverage
All files 83%
translator/src/translator/__init__.py 0%
translator/src/translator/exceptions.py 50%
translator/src/translator/gobgp.py 82%
translator/src/translator/settings.py 91%
translator/src/translator/shared.py 81%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 379c7ba

@github-actions

Copy link
Copy Markdown

Django Coverage

File Coverage
All files 78%
src/config/consumers.py 59%
src/config/urls.py 69%
src/config/settings/base.py 69%
src/config/settings/local.py 72%
src/scram/route_manager/admin.py 71%
src/scram/route_manager/models.py 79%
src/scram/route_manager/views.py 88%
src/scram/route_manager/api/serializers.py 92%
src/scram/route_manager/api/views.py 63%
src/scram/shared/shared_code.py 56%
src/scram/templates/403.html 93%
src/scram/templates/404.html 93%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 379c7ba

Comment thread translator/src/translator/gobgp.py
Comment thread Makefile

@samoehlert samoehlert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and is a big win. Much clearer and more reliable with specific types.

@crankynetmaam
crankynetmaam merged commit b4dee15 into main Aug 11, 2026
14 checks passed
@crankynetmaam
crankynetmaam deleted the topic/fern/gobgp-v4 branch August 11, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade GoBGP

2 participants