feat(translator): use the shiny new rewritten GoBGP Protobufs and upgrade GoBGP - #241
Merged
Conversation
|
Scheduler Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 379c7ba |
|
Scripts Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 379c7ba |
|
Translator Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 379c7ba |
|
Django Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 379c7ba |
samoehlert
reviewed
Aug 11, 2026
samoehlert
reviewed
Aug 11, 2026
samoehlert
approved these changes
Aug 11, 2026
samoehlert
left a comment
Collaborator
There was a problem hiding this comment.
This looks great and is a big win. Much clearer and more reliable with specific types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades us to the latest GoBGP version and uses the new protobufs (yay!) so we don't have to do the annoying manual packing of attributes.
Closes #212 and I think #214 because I'm happy (enough) with how this actually handles generating things with a real honest to god useful protobuf. It's at least more functional (and we just touch a init.py to seal the deal towards packagifying the grpc code. )