Skip to content

Comments

Provide a "--disable-profiling" option with configure #760

Closed
rollingslack wants to merge 1 commit intoesnet:masterfrom
rollingslack:master
Closed

Provide a "--disable-profiling" option with configure #760
rollingslack wants to merge 1 commit intoesnet:masterfrom
rollingslack:master

Conversation

@rollingslack
Copy link
Contributor

to turn off profiling flags + Bump to autotools 1.16.1

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies: master

  • Issues fixed (if any): Cross-compilation and profiling #749

  • Brief description of code changes (suitable for use as a commit message):
    Provide a command line option with the configure script to disable profiling flags for gprof. (--disable-profiling)

@bmah888
Copy link
Contributor

bmah888 commented Jun 25, 2018

Thanks for the pull request...I've been wondering how to do this.

For future reference it's probably easiest to just submit changes to the files such as configure.ac and Makefile.am. After merging we'll re-run bootstrap.sh to regenerate the Makefile.in, etc. files. I admit we didn't communicate that.

Haven't really had a chance to play with the change yet but looking forward to it.

@bmah888 bmah888 self-assigned this Jun 26, 2018
@bmah888 bmah888 added this to the 3.7 milestone Jun 26, 2018
@bmah888
Copy link
Contributor

bmah888 commented Jun 28, 2018

I just tried this out...even if I use --disable-profiling, it still tries to build iperf3-profile, even without the profiling goop. Going to try something, will add another comment if this works.

@rollingslack
Copy link
Contributor Author

thanks @bmah888 - I did not look into the bootstrap shell script. Would have made a few things much simpler. I'll have a look at this and submit a new PR with just the configure.ac and makefile.am changes.
Do you want to go ahead and reject this PR to clear the decks for that ?

@bmah888
Copy link
Contributor

bmah888 commented Jun 29, 2018

Sure I can close this PR (I guess you have done that too?). Looking forward to seeing the new version. Thanks for working on this, as you probably know a number of people have asked for it.

@rollingslack
Copy link
Contributor Author

#763 is the new PR !

This was referenced Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants