Skip to content

Comments

Issue 595#767

Merged
bmah888 merged 2 commits intoesnet:masterfrom
rollingslack:issue-595
Aug 9, 2018
Merged

Issue 595#767
bmah888 merged 2 commits intoesnet:masterfrom
rollingslack:issue-595

Conversation

@rollingslack
Copy link
Contributor

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies: master

  • Issues fixed (if any): partially addresses libiperf catchup #595

  • Brief description of code changes (suitable for use as a commit message): Add libiperf api for getting iperf version

Notes

  • The extended version info (CJSON, system info, et al) is not present with this API.
  • Makefile.am has changes to account for a new api test file. I've not added the changes to Makefile.in - per Provide a "--disable-profiling" option with configure  #760 (comment). So, this will require running the bootstrap.sh and regenerating the Makefile.in and merging before it can go into master.
    If I need to
  • I've introduced a new placeholder for API tests as t_api.c - this also runs on make check. This is not really required for this simple API change, but is probably useful for housing/adding on other API check tests later.

Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@bmah888 bmah888 merged commit beac688 into esnet:master Aug 9, 2018
@rollingslack rollingslack deleted the issue-595 branch August 9, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants