Honor file path when download ID is invalid - #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filePathwhendownloadIdlookup fails, is incomplete, or has no resolved filenamedownloadIdover a potentially stale pathupload_filecontract and add regression coverage for the avatar-upload failure shapeRoot cause
The Chrome upload handler always prioritized
downloadId. When a model supplied both a valid browser-local path and an invented ID such as0, the handler returned “No download found” before validating or using the path, causing repeated retries and loop detection.Impact
Instructions such as “Pass that exact absolute path to the browser file-upload tool” now work even if the model accidentally includes an invalid download ID. ID-only failures still recommend
list_downloads.Validation
git diff --check: passedpackage.jsonis26.0.7while the newest changelog entry is26.0.0