Support Gmail expand-all keyboard shortcut - #226
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a788a756b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ArrowUp: { code: 'ArrowUp', keyCode: 38 }, | ||
| ArrowRight: { code: 'ArrowRight', keyCode: 39 }, | ||
| ArrowDown: { code: 'ArrowDown', keyCode: 40 }, | ||
| ';': { code: 'Semicolon', keyCode: 186 }, |
There was a problem hiding this comment.
On actual Firefox, the legacy key code for the semicolon key is 59 rather than Chromium's 186, and Firefox may ignore the non-standard keyCode member passed to the KeyboardEvent constructor. Consequently, Gmail or another shortcut handler that uses the legacy key code will not recognize this newly advertised Firefox shortcut. The added fixture does not validate Firefox behavior because test/fixtures/run.mjs launches Chromium once and merely injects each browser's content-script source into it; exercise this path in Firefox and initialize metadata compatible with that browser.
Useful? React with 👍 / 👎.
|
@codex pls review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
press_keysto dispatch the unmodified;key in Chrome and FirefoxCLICKpermission for the page shortcut while keepingpress_keysunavailable in Ask modeWhy
The Gmail adapter recommends
;when the top-level Expand all control is unavailable, butpress_keyspreviously rejected that key before dispatch.Impact
Gmail's adapter fallback can now expand a full conversation in Act mode. Ask mode remains read-only.
Validation
npm run test:fixtures— 127 passed, 0 failednpm run test:security— 60/60 passednode test/run.js— 1431 passed; one pre-existing release-history mismatch remains onmain(package.json26.0.9 vs newestCHANGELOG.mdentry 26.0.0)git diff --check